Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/templates #349

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Feature/templates #349

merged 3 commits into from
Feb 21, 2022

Conversation

alexcos20
Copy link
Member

Closes #335

Moved FixedRate & Dispenser to template type, because we could have multiple.

@alexcos20 alexcos20 added this to the V4 milestone Feb 21, 2022
@alexcos20 alexcos20 requested a review from mihaisc February 21, 2022 09:17
@alexcos20 alexcos20 self-assigned this Feb 21, 2022
Copy link
Contributor

@mihaisc mihaisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good at a quick glance, didn't test it

@alexcos20 alexcos20 merged commit f5c7eea into v4main Feb 21, 2022
@alexcos20 alexcos20 deleted the feature/templates branch February 21, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factory templates
2 participants