Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual bump test #181

Merged
merged 41 commits into from
Aug 3, 2021
Merged

Manual bump test #181

merged 41 commits into from
Aug 3, 2021

Conversation

mihaisc
Copy link
Contributor

@mihaisc mihaisc commented Jul 30, 2021

Bumped ocean.js and @graphprotocol/graph-cli.
Updated git actions to node 16.

@mihaisc
Copy link
Contributor Author

mihaisc commented Jul 30, 2021

I'm currently stuck. Tests run ok locally. Not sure exactly why the subgraph is not deployed properly in github actions, in theory nothing should have changed with these dependencies.
In the initial setup of the tests some run commands were run in parallel and npm run deploy was run before npm run create.

@kremalicious
Copy link
Contributor

kremalicious commented Aug 2, 2021

Does this help? Ran into some GitHub Actions specific issue with our address file env vars over in ocean.js: https://github.com/oceanprotocol/ocean.js/blob/main/.github/workflows/ci.yml#L88-L91

@mihaisc
Copy link
Contributor Author

mihaisc commented Aug 2, 2021

address seems ok here, we kinda put it everywhere, so it not that

@alexcos20
Copy link
Member

found the problem.

  • with graph-cli 0.18.0 works like a charm
  • with graph-cli 0.21.X , it breaks..

@kremalicious
Copy link
Contributor

Haha, so seems we did find another project using minor version bumps for major changes

@mihaisc mihaisc requested a review from alexcos20 August 3, 2021 07:50
@mihaisc mihaisc merged commit 6146674 into main Aug 3, 2021
@mihaisc mihaisc deleted the test/bump branch August 3, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants