-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dispenser #106
add dispenser #106
Conversation
waiting for a new ocean.js, in order to have tests as well |
Signed-off-by: mihaisc <[email protected]>
I tried running it locally with Barge but I got an error, Let me know if I did anything wrong, I ran:
Barge is running in a separate terminal with |
Signed-off-by: mihaisc <[email protected]>
FIxed now. |
Thanks, I'll test it again |
Signed-off-by: mihaisc <[email protected]>
Seems to work well now. By the way, I added the |
It seems like the tests are failing slightly randomly, I have run them a couple of times locally and they pass sometimes but not all the time. The sleep time may need to be increased |
Signed-off-by: mihaisc <[email protected]>
Signed-off-by: mihaisc <[email protected]>
Signed-off-by: mihaisc <[email protected]>
@jamiehewitt15 yep, it depends on what resources the graph has. I increased all sleep times, hopefully 3 seconds is enough |
Ready from my point of view. @alexcos20 remove the WIP label if no more work is needed here. |
Seems ok to me too, I have approved |
Closes #90