OpamConfigCommand: avoid capturing the Unix.environment at top level #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a continuation of ocaml#4111 ocaml#4789, this time in OpamConfigCommand, which captures (via a call to OpamInitDefault.init_config ()) the Unix environment at startup. This is crucial if opam-client is used as a library that modifies the environment before execution of opam functionality.
|
NB I |
|
Ah nice, thanks. I'm working on the latest 2.1 release, and whenever I encounter issues I try to fix them on the 2.1 branch. A 2.1.3 release would be very welcome then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #4111 #4789, this time in OpamConfigCommand, which
captures (via a call to OpamInitDefault.init_config ()) the Unix environment
at startup. This is crucial if opam-client is used as a library that modifies
the environment before execution of opam functionality.
This PR is for the 2.1 branch but should apply cleanly on the main branch as well. Are there plans to continue 2.1, or will that version be abandoned in favour of 2.2?