Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates on reftests #4913

Merged
merged 14 commits into from
Nov 23, 2021
Merged

updates on reftests #4913

merged 14 commits into from
Nov 23, 2021

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Nov 15, 2021

  • Fix meld reftest: open only with failing ones
  • Automatically replace opam bin path, add BASEDIR environment variable
  • Add grep -v command, helper instead of just using sed
  • On replacement, get the latest group for the end of the match, not the first one (in case groups are defined in regexp) replace all occurrences [hackish]
  • Apply grep & seds on file order
  • Precise OPAMTMP regexp, hexa instead of 'alphanum to avoid confusion with BASEDIR
  • Substitution in regexp pattern (for environment variables)
  • Substitution for opam-cat content
  • Untie opam root version test from current opam root/version
  • some tests update

@rjbou rjbou requested a review from AltGr November 15, 2021 15:33
@rjbou rjbou force-pushed the rftst branch 2 times, most recently from c782033 to 1a284a0 Compare November 17, 2021 19:42
@rjbou rjbou removed the request for review from AltGr November 23, 2021 09:44
@rjbou rjbou merged commit 87fb868 into ocaml:master Nov 23, 2021
rjbou added a commit to rjbou/opam that referenced this pull request Apr 27, 2022
rjbou added a commit to rjbou/opam that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant