-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: cmdliner.1.3.0 #25924
Add: cmdliner.1.3.0 #25924
Conversation
The CI has error but they are unrelated to this package:
|
Thanks |
Thank you all ! |
I'm not sure whether this is the right place, but I observe on arm32 and x86-32 CI some issues with cmdliner 1.3.0:
The job is e.g. https://ocaml.ci.dev/github/robur-coop/miragevpn/commit/e6075ab9a739380fa13ce53d89606fc4dfdb6573/variant/debian-12-5.2_arm32_opam-2.1 but also at https://ocaml.ci.dev/github/mirage/mirage-tcpip/commit/4bdb2b509bf42d50163d6138893989ea5775bb4c/variant/debian-12-5.2_arm32_opam-2.1 and https://ocaml.ci.dev/github/mirage/mirage-tcpip/commit/4bdb2b509bf42d50163d6138893989ea5775bb4c/variant/debian-12-5.2_x86_32_opam-2.1 As said, I've no clue what the root of the issue is, neither do I have a 32bit system to reproduce this issue. |
The
I suspect that (I guess on 32-bits |
The offending line. I opened ocaml/dune#10563 in |
Not sure if it's possible to express the conflict with |
Yes, using:
|
But
but according to the docs that's not allowed. |
Thanks for your investigation, debugging, providing a fix, and opening issue and PR upstream. What I remember from optional dependencies days in MirageOS and opam, the conjunction is not allowed in conflicts. What we then did was a So, in this case, something along these lines may work:
Where "no-dune" would be a package that conflicts with "dune". But we can as well try to motivate the dune team to release a fixed version and not bother with old releases (of course, it would be nice if there'd be a way to express this conflict in opam, I hope someone else has an idea). :) |
we're going to release a dune version with the fix today. |
Maybe we should have something along the lines of |
Done in #25931 |
cmdliner.1.3.0
home, doc, issuesDeclarative definition of command line interfaces for OCaml
cmdliner
v1.3.0 2024-05-23 La Forclaz (VS)Cmdliner.Term.Syntax
(#173). Thanks to BenoitMontagu for suggesting, Gabriel Scherer for reminding us of language
punning obscurities and Sebastien Mondet for strengthening the case
to add them.
(#185). Thanks to @kit-ty-kate for the report.
$(iname)
in the defaultintroduction of the
ENVIRONMENT
section. Follow up to#168.
Cmd.eval_value'
a variation onCmd.eval_value
.Use
b0 -- .opam publish cmdliner.1.3.0
to update the pull request.