Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ppxlib (0.32.1~5.2preview) #25267

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

NathanReb
Copy link
Contributor

Preview release with OCaml 5.2 compatibility

CHANGES:

Preview release with OCaml 5.2 compatibility

CHANGES:

- Add support for OCaml 5.2

- Insert errors from caught located exceptions in place of the code that
  should have been generated by context-free rules. (ocaml#472, @NathanReb)

Signed-off-by: Nathan Rebours <[email protected]>
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: the ocaml package is a meta package and does not deal with its alpha/beta/rc versions. To special case those you need to conflict with specific versions of the ocaml-base-compiler and ocaml-variants packages.

Otherwise LGTM

@raphael-proust
Copy link
Contributor

LGTM. All the weirdness is due to the preview status.

Although I haven't checked the CI results yet because it's not finished.

@mseri
Copy link
Member

mseri commented Feb 16, 2024

I did not notice regressions in the ci failures

@mseri mseri merged commit dd420d6 into ocaml:master Feb 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants