benchpress: add missing result dependency #23841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotted in ocaml#23834 revdeps
|
Failure, for future reference: |
Lower bounds tests fail with
```
#=== ERROR while compiling gnuplot.0.6 ========================================#
# context 2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.12.1 | file:///home/opam/opam-repository
# path ~/.opam/4.12/.opam-switch/build/gnuplot.0.6
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p gnuplot -j 127
# exit-code 1
# env-file ~/.opam/log/gnuplot-7-8c3e4f.env
# output-file ~/.opam/log/gnuplot-7-8c3e4f.out
### output ###
# ocamlc src/.gnuplot.objs/byte/gnuplot.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.gnuplot.objs/byte -I /home/opam/.opam/4.12/lib/ISO8601 -intf-suffix .ml -no-alias-deps -o src/.gnuplot.objs/byte/gnuplot.cmo -c -impl src/gnuplot.ml)
# File "src/gnuplot.ml", line 62, characters 4-32:
# 62 | ISO8601.Permissive.pp_format out fmt d tz
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value ISO8601.Permissive.pp_format
# ocamlopt src/.gnuplot.objs/native/gnuplot.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlopt.opt -w -40 -g -I src/.gnuplot.objs/byte -I src/.gnuplot.objs/native -I /home/opam/.opam/4.12/lib/ISO8601 -intf-suffix .ml -no-alias-deps -o src/.gnuplot.objs/native/gnuplot.cmx -c -impl src/gnuplot.ml)
# File "src/gnuplot.ml", line 62, characters 4-32:
# 62 | ISO8601.Permissive.pp_format out fmt d tz
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value ISO8601.Permissive.pp_format
```
Failure: ``` #=== ERROR while compiling benchpress.0.1 =====================================# # context 2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.04.2 | pinned(https://github.com/sneeuwballen/benchpress/archive/0.1.tar.gz) # path ~/.opam/4.04/.opam-switch/build/benchpress.0.1 # command ~/.opam/opam-init/hooks/sandbox.sh build dune build @install -p benchpress -j 255 # exit-code 1 # env-file ~/.opam/log/benchpress-7-aa2d84.env # output-file ~/.opam/log/benchpress-7-aa2d84.out ### output ### # ocaml-protoc src/core/api_pb.{ml,mli},src/core/api_pp.{ml,mli},src/core/api_types.{ml,mli} # Generating ./api_types.mli # Generating ./api_types.ml # Generating ./api_pb.mli # Generating ./api_pb.ml # Generating ./api_pp.mli # Generating ./api_pp.ml # ocamlopt src/core/.benchpress.objs/native/benchpress__Misc.{cmx,o} # File "_none_", line 1: # Warning 58: no cmx file was found in path for module ISO8601, and its interface was not compiled with -opaque # ocamlc src/core/.benchpress.objs/byte/benchpress__Test.{cmi,cmo,cmt} (exit 2) # (cd _build/default && /home/opam/.opam/4.04/bin/ocamlc.opt -w -40 -warn-error -3-32-34-50 -safe-string -g -bin-annot -I src/core/.benchpress.objs/byte -I /home/opam/.opam/4.04/lib/ISO8601 -I /home/opam/.opam/4.04/lib/bytes -I /home/opam/.opam/4.04/lib/cmdliner -I /home/opam/.opam/4.04/lib/containers -I /home/opam/.opam/4.04/lib/containers/monomorphic -I /home/opam/.opam/4.04/lib/containers/sexp -I /home/opam/.opam/4.04/lib/containers/thread -I /home/opam/.opam/4.04/lib/containers/unix -I /home/opam/.opam/4.04/lib/csv -I /home/opam/.opam/4.04/lib/decoders -I /home/opam/.opam/4.04/lib/gnuplot -I /home/opam/.opam/4.04/lib/iter -I /home/opam/.opam/4.04/lib/logs -I /home/opam/.opam/4.04/lib/ocaml-protoc -I /home/opam/.opam/4.04/lib/ocaml/threads -I /home/opam/.opam/4.04/lib/printbox -I /home/opam/.opam/4.04/lib/re -I /home/opam/.opam/4.04/lib/re/perl -I /home/opam/.opam/4.04/lib/result -I /home/opam/.opam/4.04/lib/seq -I /home/opam/.opam/4.04/lib/sqlite3 -I /home/opam/.opam/4.04/lib/sqlite3_utils -I /home/opam/.opam/4.04/lib/uchar -I /home/opam/.opam/4.04/lib/uuidm -no-alias-deps -open Benchpress -o src/core/.benchpress.objs/byte/benchpress__Test.cmo -c -impl src/core/Test.ml) # File "src/core/Test.ml", line 538, characters 6-14: # Error: Unbound value Uuidm.pp ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spotted in #23834 revdeps