5 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.1/ocaml-bls12-381-0.4.1.tar.bz2 #18112

dannywillems · 2021-02-08T17:07:22Z

This pull-request concerns:
-bls12-381.0.4.1: Virtual package for BLS12-381 primitives
-bls12-381-gen.0.4.1: Functors to generate BLS12-381 primitives based on stubs
-bls12-381-js.0.4.1: JavaScript version of BLS12-381 primitives implementing the virtual
package bls12-381
-bls12-381-js-gen.0.4.1: Functors to generate BLS12-381 JavaScript primitives based on stubs
-bls12-381-unix.0.4.1: UNIX version of BLS12-381 primitives implementing the virtual package
bls12-381

This new release brings JavaScript support using js_of_ocaml. More information can be found in the README.

For the UNIX version, nothing changes compared to before, except adding bls12-381-unix when writing an executable.
For the JavaScript version, the integration does rely on a communication with a wasm module, generated by wasm-bindgen from the same source code the UNIX package uses (rustc-bls12-381, integrated in tezos-rust-libs, see https://gitlab.com/tezos/tezos-rust-libs/-/merge_requests/1). js_of_ocaml is used on the OCaml side to generate JavaScript code which is going to call the wasm module and read/write the wasm memory.

I am not aware of any previous attempt on releasing OPAM packages using Rust code with a JavaScript support (using the same Rust dependency). This solution does work, but a bunch of improvements can be made. In particular, the JavaScript binding could be improved by writing a library « à la ctypes », see https://gitlab.com/nomadic-labs/tezos/-/issues/230 for the idea. If there is any other attempt, please share. There is an ongoing work to do the same for Sapling in Tezos, and feedbacks are welcome.

I also started (but never finished, even if the most interesting parts, like pointers are not written but used in these packages...) a bunch of README and code to write web applications using OCaml and Rust: https://gitlab.com/dannywillems/web-ocaml-rust-tuto.

Homepage: https://gitlab.com/dannywillems/ocaml-bls12-381
Source repo: git+https://gitlab.com/dannywillems/ocaml-bls12-381.git
Bug tracker: https://gitlab.com/dannywillems/ocaml-bls12-381/issues

🐫 Pull-request generated by opam-publish v2.0.2

camelus · 2021-02-08T18:06:21Z

Commit: 14c096a

@dannywillems has posted 33 contributions.

☀️ All lint checks passed `14c096a`

These packages passed lint tests: bls12-381-gen.0.4.1, bls12-381-js-gen.0.4.1, bls12-381-js.0.4.1, bls12-381-unix.0.4.1, bls12-381.0.4.1

☀️ Installability check (+5)

new installable packages (5): bls12-381.0.4.1 bls12-381-gen.0.4.1 bls12-381-js.0.4.1 bls12-381-js-gen.0.4.1 bls12-381-unix.0.4.1

dannywillems · 2021-02-08T19:45:39Z

Looks like there is an issue with ocamlformat.0.16.0 😕

dannywillems · 2021-02-08T19:47:02Z

Also, looks like npm is missing. I am not sure using npm from the package manager is the best. Should I use anyway? Tests require it as it does run in node.

kit-ty-kate · 2021-02-08T20:00:04Z

Looks like there is an issue with ocamlformat.0.16.0 confused

what was the issue? I couldn't see any failures related to ocamlformat

kit-ty-kate · 2021-02-08T20:00:53Z

I pushed a fix, could you return the fix upstream?

dannywillems · 2021-02-08T20:23:09Z

I pushed a fix, could you return the fix upstream?

Done in https://gitlab.com/dannywillems/ocaml-bls12-381/-/commit/fe9bfca313955a00e7cd11f725e7b4bac8eee1e5

dannywillems · 2021-02-08T20:24:23Z

Looks like there is an issue with ocamlformat.0.16.0 confused

what was the issue? I couldn't see any failures related to ocamlformat

Builds failed with a cyclic deps error for bisect_ppx 2.6 and ocamlformat 0.16.0.

dannywillems · 2021-02-08T20:26:00Z

Like here

dannywillems · 2021-02-09T10:57:34Z

It looks like more packages are affected by the circular dependencies. The CI says it is fine, but the commands fail with an error. It is introduced by bisect_ppx 2.6.0. bisect_ppx is a dependency of ff and ff-pbt, with a version ">= 2.5". I will add a temporary fix here with bisect_ppx < "2.6.0".

dannywillems · 2021-02-09T12:44:02Z

Some jobs are failing because the node version is old, see - node: bad option: --experimental-wasm-modules in here. Tests require the option --experimental-wasm-modules, introduced in Node 12.3.0, see https://nodejs.org/tr/blog/uncategorized/10-lts-to-12-lts/#notable-changes-in-node-js-12-3-0.
And I suppose an old version in the tests (by using conf-npm which uses the system packages, not recommended for NPM/Node).
EDIT: it looks like this option is not required to run test tests correctly. I will update the test command. As it is not too late because it is not used yet, I will update the release tag, and include the changes we talked earlier.

For OCaml 4.12, should I add a constraint on the OCaml version as jsoo does? https://github.com/ocaml/opam-repository/blob/master/packages/js_of_ocaml-compiler/js_of_ocaml-compiler.3.8.0/opam#L17 and https://github.com/ocaml/opam-repository/blob/master/packages/js_of_ocaml-compiler/js_of_ocaml-compiler.3.7.1/opam.

On debian-unstable, it is failing because of

- npm ERR! errno -13
- npm ERR! Error: EACCES: permission denied, open '/home/opam/.opam/4.11/.opam-switch/build/bls12-381-js.0.4.1/_build/default/test/js/node/package.json'
- npm ERR!  [Error: EACCES: permission denied, open '/home/opam/.opam/4.11/.opam-switch/build/bls12-381-js.0.4.1/_build/default/test/js/node/package.json'] {
- npm ERR!   errno: -13,
- npm ERR!   code: 'EACCES',
- npm ERR!   syscall: 'open',
- npm ERR!   path: '/home/opam/.opam/4.11/.opam-switch/build/bls12-381-js.0.4.1/_build/default/test/js/node/package.json'
- npm ERR! }

….1/ocaml-bls12-381-0.4.1.tar.bz2

kit-ty-kate · 2021-02-10T12:28:43Z

Is there no way of having tests without npm? If not I'll simply disable them.

dannywillems · 2021-02-10T13:16:37Z

Is there no way of having tests without npm? If not I'll simply disable them.

No it is not possible.

kit-ty-kate · 2021-02-10T19:23:26Z

packages/bls12-381-gen/bls12-381-gen.0.4.1/opam

+homepage: "https://gitlab.com/dannywillems/ocaml-bls12-381"
+bug-reports: "https://gitlab.com/dannywillems/ocaml-bls12-381/issues"
+depends: [
+  "ocaml" {>= "4.08" & < "4.12"}


One last question and it should be good to go: why is it not available on 4.12? If there is any issue I'll fix your package but if that's "just in case" I'd rather not to have that. That would add work to both of us:

you by making another release for 4.12

me by having to understand why the package was constrained in the first place and pushing the change anyway.

If it's a real incompatibility however that's totally fine.

It is compatible with 4.12, but the CI here was failing because jsoo was not available for 4.12. I thought adding the dep was the way to go.

I'm surprised, was it really failing or just skipped? It's not supposed to fail.

This is to try to quickfix through the problem reported here: ocaml/opam-repository#18112 (comment) Travesty doesn't explicitly use bisect_ppx itself, so this should be removed as soon as practical.

kit-ty-kate · 2021-02-12T01:37:46Z

packages/bls12-381-gen/bls12-381-gen.0.4.1/opam

+  "dune" {>= "2.7"}
+  "ff-sig" {>= "0.6.1" & < "0.7.0"}
+  "zarith" {>= "1.10" & < "2.0"}
+  "bisect_ppx" {with-test & >= "2.5" & < "2.6.0"}


Same question with that actually. I believe this is just a bug fixed by #18141

Yes I do confirm < "2.6.0" is just a temporary workaround because the tests were failing in the CI here.

kit-ty-kate · 2021-02-12T14:00:22Z

Thanks!

dannywillems · 2021-02-15T12:28:41Z

Thanks for merging.
Looks like ocaml/dune#4195 does also happen when running opam install bls12-381-unix. I was a bit confident it passed the CI here.

See PR ocaml/opam-repository#18112

5 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4…

4ce7cb7

….1/ocaml-bls12-381-0.4.1.tar.bz2

dannywillems force-pushed the opam-publish-bls12-381-bls12-381-gen-bls12-381-js-bls12-381-js-gen-bls12-381-unix.0.4.1 branch from cff08c2 to 4ce7cb7 Compare February 9, 2021 14:07

kit-ty-kate added the question label Feb 10, 2021

bls12-381-js*.0.4.1: Disable tests (uses experimental features on npm)

2fa570c

kit-ty-kate removed the question label Feb 10, 2021

kit-ty-kate reviewed Feb 10, 2021

View reviewed changes

kit-ty-kate added the question label Feb 10, 2021

MattWindsor91 mentioned this pull request Feb 11, 2021

Cyclic dependencies involving bisect_ppx 2.6.0 #18134

Closed

kit-ty-kate reviewed Feb 12, 2021

View reviewed changes

bls-12-381-*.0.4.1: Remove unnecessary constraints

14c096a

kit-ty-kate added consider for merge and removed question labels Feb 12, 2021

kit-ty-kate merged commit 218b1f7 into ocaml:master Feb 12, 2021

dannywillems deleted the opam-publish-bls12-381-bls12-381-gen-bls12-381-js-bls12-381-js-gen-bls12-381-unix.0.4.1 branch February 15, 2021 10:55

dannywillems mentioned this pull request Feb 15, 2021

"Rule failed to generate the following targets" with virtual package ocaml/dune#4195

Closed

dannywillems mentioned this pull request Feb 15, 2021

Virtual_rules: use copy instead of symlink when copying signatures ocaml/dune#4233

Merged

craigfe pushed a commit to craigfe/ocaml-bls12-381 that referenced this pull request Jun 1, 2021

Remove conf-npm as it was not recommended in the public opam repo PR

d9783d5

See PR ocaml/opam-repository#18112

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.1/ocaml-bls12-381-0.4.1.tar.bz2 #18112

5 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.1/ocaml-bls12-381-0.4.1.tar.bz2 #18112

dannywillems commented Feb 8, 2021 •

edited

Loading

camelus commented Feb 8, 2021 •

edited

Loading

dannywillems commented Feb 8, 2021

dannywillems commented Feb 8, 2021

kit-ty-kate commented Feb 8, 2021

kit-ty-kate commented Feb 8, 2021

dannywillems commented Feb 8, 2021

dannywillems commented Feb 8, 2021

dannywillems commented Feb 8, 2021

dannywillems commented Feb 9, 2021

dannywillems commented Feb 9, 2021 •

edited

Loading

kit-ty-kate commented Feb 10, 2021

dannywillems commented Feb 10, 2021

kit-ty-kate Feb 10, 2021

dannywillems Feb 11, 2021

kit-ty-kate Feb 12, 2021

kit-ty-kate Feb 12, 2021

dannywillems Feb 12, 2021

kit-ty-kate commented Feb 12, 2021

dannywillems commented Feb 15, 2021

5 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.1/ocaml-bls12-381-0.4.1.tar.bz2 #18112

5 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.1/ocaml-bls12-381-0.4.1.tar.bz2 #18112

Conversation

dannywillems commented Feb 8, 2021 • edited Loading

camelus commented Feb 8, 2021 • edited Loading

☀️ All lint checks passed 14c096a

☀️ Installability check (+5)

dannywillems commented Feb 8, 2021

dannywillems commented Feb 8, 2021

kit-ty-kate commented Feb 8, 2021

kit-ty-kate commented Feb 8, 2021

dannywillems commented Feb 8, 2021

dannywillems commented Feb 8, 2021

dannywillems commented Feb 8, 2021

dannywillems commented Feb 9, 2021

dannywillems commented Feb 9, 2021 • edited Loading

kit-ty-kate commented Feb 10, 2021

dannywillems commented Feb 10, 2021

kit-ty-kate Feb 10, 2021

Choose a reason for hiding this comment

dannywillems Feb 11, 2021

Choose a reason for hiding this comment

kit-ty-kate Feb 12, 2021

Choose a reason for hiding this comment

kit-ty-kate Feb 12, 2021

Choose a reason for hiding this comment

dannywillems Feb 12, 2021

Choose a reason for hiding this comment

kit-ty-kate commented Feb 12, 2021

dannywillems commented Feb 15, 2021

dannywillems commented Feb 8, 2021 •

edited

Loading

camelus commented Feb 8, 2021 •

edited

Loading

☀️ All lint checks passed `14c096a`

dannywillems commented Feb 9, 2021 •

edited

Loading