Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain js_of_ocaml for Lwt 4.0.0 #11788

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Constrain js_of_ocaml for Lwt 4.0.0 #11788

merged 1 commit into from
Apr 14, 2018

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Apr 13, 2018

cc @hannesm @hhugo

Constraints are based on looking in the git history of js_of_ocaml. The dependency on lwt.log first appeared in 2.3, and seems not to be guarded by its own condition.

EDIT: see #11708 (comment).

@camelus
Copy link
Contributor

camelus commented Apr 13, 2018

✅ All lint checks passed 55d1073
  • These packages passed lint tests: js_of_ocaml-lwt.3.0.1, js_of_ocaml-lwt.3.0.2, js_of_ocaml-lwt.3.0, js_of_ocaml-lwt.3.1.0, js_of_ocaml.2.3, js_of_ocaml.2.4.1, js_of_ocaml.2.4, js_of_ocaml.2.5, js_of_ocaml.2.6, js_of_ocaml.2.7, js_of_ocaml.2.8.1, js_of_ocaml.2.8.2, js_of_ocaml.2.8.3, js_of_ocaml.2.8.4, js_of_ocaml.2.8

✅ Installability check (8700 → 8700)

@hhugo
Copy link
Contributor

hhugo commented Apr 13, 2018

ack

@hannesm
Copy link
Member

hannesm commented Apr 14, 2018

thanks, I'll merge this. there's an issue discovered by Travis CI:

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[ERROR] curl: code 404 while downloading
        http://ocsigen.org/download/lwt-2.4.3.tar.gz
[ocamlfind.1.7.3-1] http://download.camlcity.org/download/findlib-1.7.3.tar.gz downloaded
[menhir.20140422] http://cristal.inria.fr/~fpottier/menhir/menhir-20140422.tar.gz downloaded
[ERROR] The sources of the following couldn't be obtained, aborting:
          - lwt.2.4.3
        (This may be fixed by running 'opam update')

and a local test lead to the same result, lwt-2.4.3.tar.gz is no longer available from that URL //cc @aantron

@hannesm hannesm merged commit 2cf5c96 into ocaml:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants