Mark Slacko as potentially compatible with Lwt 4.0 #11760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the nice comment by @aantron in ocaml#11708 (comment) slacko fails because it expects lwt.log to exist without depending on the lwt_log message. This came to a surprise to me since Slacko does not do any logging at all, so constraining it does not seem to be useful. Looking in the CI log https://ci.ocamllabs.io/log/saved/docker-run-e97b0a51ae9b04229ade4297103e6c79/e87df7e1b52e41541b179ab4024a538bfd0b1484 I can see that the error came from a module in "lwt/cohttp_lwt_unix.ml" which happens when building cohttp.0.21.1. Therefore I would like to correct the dependency here. If any version of cohttp < 0.99 would be compatible with Lwt 4 (e.g. if someone does a maintenance release), so would slacko.
✅ All lint checks passed c7c48d7
✅ Installability check (8681 → 8681) |
|
Argh, sorry about that. Indeed, for reference of others, we also constrained a lot of old versions of |
|
Yes, I was not expecting it to work with Lwt 4.0 in any case but it would be rejected due to cohttp instead. Which I think is the right place to place the constraints 🙂
The next version of Slacko should be compatible with modern Lwt anyway, since I think I have all necessary changes in master and depend on more recent cohttp versions. I'll try to release that soon.
|
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the nice comment by @aantron in #11708 (comment) slacko fails because it expects
lwt.logto exist without depending on thelwt_logmessage.This came to a surprise to me since Slacko does not do any logging at all, so constraining it does not seem to be useful.
Looking in the CI log
https://ci.ocamllabs.io/log/saved/docker-run-e97b0a51ae9b04229ade4297103e6c79/e87df7e1b52e41541b179ab4024a538bfd0b1484 I can see that the error came from a module in "lwt/cohttp_lwt_unix.ml" which happens when building
cohttp.0.21.1.Therefore I would like to correct the dependency here. If any version of
cohttp<0.99would be compatible with Lwt 4 (e.g. if someone does a maintenance release), so would slacko.