Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf-snappy #11676

Merged
merged 10 commits into from
Apr 3, 2018
Merged

conf-snappy #11676

merged 10 commits into from
Apr 3, 2018

Conversation

gasche
Copy link
Member

@gasche gasche commented Mar 27, 2018

I got caught by the lack of a fedora depext for snappy in leveldb, so here is a conf-package for snappy.

@camelus
Copy link
Contributor

camelus commented Mar 27, 2018

❌ opam-lint errors c21bd1c
  • leveldb.1.0.2 has errors:

    • error 25: Missing field 'authors'
    • warning 36: Missing field 'bug-reports'
  • leveldb.1.0.3 has errors:

    • error 25: Missing field 'authors'
    • warning 36: Missing field 'bug-reports'
  • snappy.0.0.1 has errors:

    • error 25: Missing field 'authors'
    • warning 36: Missing field 'bug-reports'
    • warning 37: Missing field 'dev-repo'
  • snappy.0.1.0 has errors:

    • error 25: Missing field 'authors'
    • warning 36: Missing field 'bug-reports'
    • warning 37: Missing field 'dev-repo'
  • These packages passed lint tests: conf-snappy.1, leveldb.1.1.0, leveldb.1.1.1, leveldb.1.1.2


✅ Installability check (8630 → 8631)
  • new installable packages (1): conf-snappy.1

@gasche
Copy link
Member Author

gasche commented Mar 28, 2018

It looks like Ubuntu/Debian don't actually provide a pkg-config package, so I'll have to write a compilation test instead.

@gasche
Copy link
Member Author

gasche commented Mar 31, 2018

I included a short compile test in the package, waiting to see what CI results give.

I don't plan for now to fix the lint errors on the snappy.* and leveldb.* packages, which are independent of the current change.

Edit: in the end I decided to fix the lint issues, as it looks like some more caretaking is required for some of those packages anyway. (I'm trying to understand the snappy build failure in the logs.)

gasche added 5 commits April 2, 2018 15:40
I can reproduce the build error from the CI on my machine:

```
$ ocamlfind ocamlopt -g -I src -linkpkg -I src src/snappy.cmxa test.cmx -o test.native
/usr/bin/ld: src/libsnappy_stubs.a(snappy_stubs.o): undefined reference to symbol '_ZTISt9exception@@GLIBCXX_3.4'
//usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
File "caml_startup", line 1:
Error: Error during linking
Command exited with code 2.
```
This comes from the use of warnings-as-errors in the build system,
which breaks the build on 4.02-added deprecation warnings. I found
no way to override OMakefile's OCAMLFLAGS variable to silence it.

(I tested that the package builds on 4.01)
```
$ ocamlfind ocamlopt -package unix,threads,oUnit -w +a-4-6-9-27-28-30..99 -warn-error +a-4-6-9-18-27-28-30..99 -annot -thread -inline 100 -I . -I ../src -o test.opt ../src/leveldb.cmxa test_00util.cmx test.cmx -linkpkg
/usr/bin/ld: ../src/libcamlleveldb.a(leveldb_stubs.o): undefined reference to symbol '_ZdlPvm@@CXXABI_1.3.9'
//usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
File "caml_startup", line 1:
Error: Error during linking
```

This error is similar to the snappy 0.0.1 error reported in
  de99d2a.
@gasche
Copy link
Member Author

gasche commented Apr 3, 2018

After some CI golfing fun, it looks like I fixed the problems in the package metadata: Travis and the V2.0 datakit are happy. I'm moving on to merge.

@gasche gasche merged commit 97dfd36 into ocaml:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants