-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf-snappy
#11676
conf-snappy
#11676
Conversation
❌ opam-lint errors c21bd1c
✅ Installability check (8630 → 8631)
|
It looks like Ubuntu/Debian don't actually provide a |
I included a short compile test in the package, waiting to see what CI results give. I don't plan for now to fix the lint errors on the snappy.* and leveldb.* packages, which are independent of the current change. Edit: in the end I decided to fix the lint issues, as it looks like some more caretaking is required for some of those packages anyway. (I'm trying to understand the |
I can reproduce the build error from the CI on my machine: ``` $ ocamlfind ocamlopt -g -I src -linkpkg -I src src/snappy.cmxa test.cmx -o test.native /usr/bin/ld: src/libsnappy_stubs.a(snappy_stubs.o): undefined reference to symbol '_ZTISt9exception@@GLIBCXX_3.4' //usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status File "caml_startup", line 1: Error: Error during linking Command exited with code 2. ```
This comes from the use of warnings-as-errors in the build system, which breaks the build on 4.02-added deprecation warnings. I found no way to override OMakefile's OCAMLFLAGS variable to silence it. (I tested that the package builds on 4.01)
``` $ ocamlfind ocamlopt -package unix,threads,oUnit -w +a-4-6-9-27-28-30..99 -warn-error +a-4-6-9-18-27-28-30..99 -annot -thread -inline 100 -I . -I ../src -o test.opt ../src/leveldb.cmxa test_00util.cmx test.cmx -linkpkg /usr/bin/ld: ../src/libcamlleveldb.a(leveldb_stubs.o): undefined reference to symbol '_ZdlPvm@@CXXABI_1.3.9' //usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status File "caml_startup", line 1: Error: Error during linking ``` This error is similar to the snappy 0.0.1 error reported in de99d2a.
Upstream PR for 4.06 support: ygrek/ocaml-snappy#1
After some CI golfing fun, it looks like I fixed the problems in the package metadata: Travis and the V2.0 datakit are happy. I'm moving on to merge. |
I got caught by the lack of a fedora depext for snappy in leveldb, so here is a conf-package for snappy.