Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map reference to url #812

Merged
merged 17 commits into from
Feb 5, 2022
Merged

Map reference to url #812

merged 17 commits into from
Feb 5, 2022

Conversation

lubegasimon
Copy link
Collaborator

Fixes #334

Julow
Julow reviewed Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

I think it would be worth adding an option for specifying the base directory, for example --prefix, because otherwise, the user will have to do it in 99% of the cases.

Julow
Julow reviewed Jan 26, 2022
View reviewed changes
panglesd
panglesd reviewed Jan 27, 2022
View reviewed changes
panglesd
panglesd reviewed Jan 27, 2022
View reviewed changes
@lubegasimon
uri -> url
64eac4f 
Signed-off-by: lubegasimon <[email protected]>
@lubegasimon lubegasimon changed the title Map reference to uri Map reference to url Jan 31, 2022
panglesd and others added 2 commits February 1, 2022 17:56
@panglesd
base -> root_url
48f1c70 
Signed-off-by: Paul-Elliot <[email protected]>
@Julow
html-url: Fix crash when root_url doesn't contain '/'
2e2d15d 
'String.rindex' raises.
Also add a special case for 'base = ""' to avoid adding a '/' out of
nowhere.
Julow
Julow approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

lubegasimon and others added 2 commits February 1, 2022 23:50
@lubegasimon @Julow
root_url -> root-url
ae6a17f 
Co-authored-by: Jules Aguillon <[email protected]>
@lubegasimon
root_url -> root-url in tests
6924de8 
Signed-off-by: lubegasimon <[email protected]>
@jonludlam jonludlam merged commit 416dda8 into master Feb 5, 2022
@jonludlam
Copy link
Member

Thanks!

@jonludlam jonludlam mentioned this pull request Feb 8, 2022
Merged
jonludlam added a commit to jonludlam/opam-repository that referenced this pull request Feb 8, 2022
@jonludlam
[new release] odoc (2.1.0)
0b0a5c8 
CHANGES:

Additions
- New subcommand to resolve references (@panglesd, @lubega-simon, ocaml/odoc#812)
- Improved rendering of long signatures (@panglesd, ocaml/odoc#782)
- Handle comments attached to open statement as floating comment, instead
  of dropping them (@panglesd, ocaml/odoc#797)
- Empty includes (containing entirely shadowed entries) are now hidden (@panglesd, ocaml/odoc#798)

Bugs fixed
- Fix a missing Result constructor during compile. This will cause some
  functor arguments to have different filenames (@jonludlam, ocaml/odoc#795)
- Better memory/disk space usage when handling module alias chains (@jonludlam, ocaml/odoc#799)
- Resolving class-type paths (ie., `val x : #c`) (@jonludlam, ocaml/odoc#809)
- Skip top-level attributes while extracting the top comment. Fix top-comment extraction with PPX preprocessing (@jorisgio, ocaml/odoc#819)
- Better handling of @canonical tags (@jonludlam, ocaml/odoc#820)
- css: improved layout (@jonludlam, @Julow, ocaml/odoc#822)
@lubegasimon lubegasimon deleted the more-work-on-uri-command branch February 18, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panglesd panglesd panglesd left review comments

@Julow Julow Julow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command for mapping identifiers to urls anchors
4 participants
@lubegasimon @jonludlam @Julow @panglesd