-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format long signature #782
Merged
jonludlam
merged 15 commits into
ocaml:master
from
panglesd:format-long-signature-with-format
Dec 8, 2021
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e75f0e0
Format type_expr with Format
panglesd 88fb40e
module in progress
panglesd 2265c36
tuples, objects and module types
panglesd 7b03ea7
forall types, package substitution and constraints
panglesd c22f52b
type decl, type_substitution, ...
panglesd a3247f5
bad formatting fixes and codefmt ignore fixes
panglesd 5af20e8
better boxing especially for named arguments
panglesd 864925e
removed debug artefact
panglesd 268a259
Add an interface file for Codefmt
Julow 02535e4
Remove unecessary dependency on fmt
Julow 64b9e57
Document: Abstract Codefmt document
Julow 8cd7890
codefmt: Improve formatting of tuples
Julow 98ee914
Updating tests
panglesd e0e08f1
Fix semantic tags version
panglesd 34b7c61
entity comment
panglesd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
open Types | ||
|
||
type t | ||
|
||
val elt : Inline.t -> t | ||
|
||
val entity : Inline.entity -> t | ||
|
||
val ignore : t -> t | ||
|
||
val span : ?attr:string -> t -> t | ||
|
||
val txt : string -> t | ||
|
||
val noop : t | ||
|
||
val cut : t | ||
|
||
val sp : t | ||
|
||
val list : ?sep:t -> f:('a -> t) -> 'a list -> t | ||
|
||
val box_hv : t -> t | ||
|
||
val box_hv_no_indent : t -> t | ||
|
||
val render : t -> Source.t | ||
|
||
val code : ?attr:string list -> t -> Inline.t | ||
|
||
val documentedSrc : t -> DocumentedSrc.t | ||
|
||
val codeblock : ?attr:Class.t -> t -> Block.t | ||
|
||
val keyword : string -> t | ||
|
||
module Infix : sig | ||
val ( ++ ) : t -> t -> t | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is getting bigger, it's time to make it more abstract: panglesd#1 (a PR to your PR, feel free to squash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I forgot to squash. I can rewrite history if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to squash unless you want to :)