Handle @canonical tags on compilation unit #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolving of root modules is no longer lazy. Return types are changed to make debugging easier if that's a problem.
Before this, @canonical tags in the top-comments of a file were ignored.
Julow
commented
Mar 24, 2021
| Some (Resolved (u.root.digest, id, u.hidden, m)) | ||
| let unit = r.resolve_unit u.root in | ||
| let m = module_of_unit unit in | ||
| Some (Resolved (u.root.digest, id, m)) |
There was a problem hiding this comment.
Resolving root modules is no longer lazy because we need to check for canonical everytime.
Is here a case where this would cause a slowdown ? (no change on base)
There was a problem hiding this comment.
Could be actually - could you do a test run on core_kernel or similar? I'd be interested to see the difference in memory usage too.
There was a problem hiding this comment.
I find no regression on core_kernel (29s in both cases). Maximum memory doesn't seem to change too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #559 (comment)
Before this,
@canonicaltags in the top-comments of a file were ignored.