Remove unneeded code and unify "utils" modules #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might make the driver incompatible with some versions of Odoc.
Option, Result, Fun and many functions in List are no longer needed since the OCaml lower bound is now 4.08. EitherMonad was not used.
This package is no longer needed since our lower-bound is 4.08. The Result prefix in Result.result and Result.Ok can be removed to make the code nicer.
Remove list operations that were not needed and move skip_until and split_at into Odoc_utils. Document related utils could be moved to Codefmt. This makes the code more consistent regarding List and String manipulations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes things that are no longer needed since the lower bounds got changed to 4.08: Shims for
Option,Fun, etc.. and theresultdependency.I then unify the various "utils" modules into
Odoc_utilsto make the code more consistent and remove more unneeded code.