Sidebar and index overhaul (2) #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting a different sidebar viewing the modules than when viewing the pages - when viewing the modules the whole hierarchy seems to disappear: 
vs 
|
jonludlam
force-pushed
the
toc-tree-2
branch
2 times, most recently
from
9f94094 to
ae8dfc4
Compare
Co-authored-by: Paul-Elliot <[email protected]>
Co-authored-by: Paul-Elliot <[email protected]>
We use the id name (corresponding to the directory name) for the page title. There is one case where we don't have access to an id: ``` $ odoc compile --output_dir _odoc --parent-id "" file.mld $ odoc link _odoc/page-file.mld $ odoc sidebar-generate -P _odoc/ ``` The parent id of page `file` is `None` and we do not have an `index.mld` with the same parent... See also the test
panglesd
added a commit
to panglesd/sherlodoc
that referenced
this pull request
Dec 9, 2024
Several changes: - Entries are now defined in the `odoc_index` library, - Entries can have new kinds (pages, source, ...) - Indexes have the form of "skeletons of entries", that can be folded. - Indexes can be created by odoc with the `odoc compile-index` command, and then consumed by sherlodoc. These changes come from: - ocaml/odoc#1228 - ocaml/odoc#1232 - ocaml/odoc#1233 - ocaml/odoc#1244 - ocaml/odoc#1250 - ocaml/odoc#1251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1232, catching up on #1220