Respect client capabilities #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix_ocamllsp___respect_client_capabilites
branch
from
859bbbc to
d81e648
Compare
rgrinberg
force-pushed
the
ps/rr/fix_ocamllsp___respect_client_capabilites
branch
from
d81e648 to
0ad2dc6
Compare
do not display code actions that aren't available to clients without showDocument support ps-id: 09AE75CD-265B-4AD4-B1E9-FF5E4451559B
to make sure we can use all these features ps-id: f9f12c10-f20b-492b-8d66-af1d54c0fa9a
rgrinberg
force-pushed
the
ps/rr/fix_ocamllsp___respect_client_capabilites
branch
from
0ad2dc6 to
8a058ba
Compare
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this pull request
Sep 19, 2022
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Oct 15, 2022
CHANGES: ## Features - Code action for inlining let bindings within a module or expression. (ocaml/ocaml-lsp#847) - Tag "unused code" and "deprecated" warnings, allowing clients to better display them. (ocaml/ocaml-lsp#848) - Refresh merlin configuration after every dune build in watch mode (ocaml/ocaml-lsp#853) ## Fixes - Respect `showDocument` capabilities. Do not offer commands or code actions that rely on this request without client support. (ocaml/ocaml-lsp#836) - Fix signatureHelp on .mll files: avoid "Document.dune" exceptions
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this pull request
Oct 17, 2022
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this pull request
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When offering commands and code actions