feature: open related code actions #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/feature__open_related_code_actions
branch
2 times, most recently
from
da32590 to
986f280
Compare
rgrinberg
force-pushed
the
ps/rr/feature__open_related_code_actions
branch
2 times, most recently
from
88aa683 to
9b89205
Compare
|
ping @ulugbekna |
|
Is it okay if I review it on Monday? |
|
Sure, next week is fine.
Rudi.
…On Jul 22, 2022, 11:51 AM -0500, Ulugbek Abdullaev ***@***.***>, wrote:
Is it okay if I review it on Monday?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ulugbekna
approved these changes
Jul 26, 2022
We can now open documents on the lsp side, which means that we can implement ml/mli toggling entirely in LSP ps-id: e8a3b313-bfc9-4f75-af26-48228f3e999a
rgrinberg
force-pushed
the
ps/rr/feature__open_related_code_actions
branch
from
9b89205 to
adbbae1
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Jul 27, 2022
CHANGES: ## Features - Code actions for jumping to related files (`.ml`, `.mli`, etc.) (ocaml/ocaml-lsp#795)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now open documents on the lsp side, which means that we can
implement ml/mli toggling entirely in LSP