Workspace symbol wrong path #671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
LGTM. Could you add a changes entry?
cc @danidickstein your PR ocaml/merlin#1219 solved a similar issue I believe
@voodoos could you have a look at this as well?
|
Looks like a reasonable change. |
tatchi
force-pushed
the
workspace-symbol-wrong-path
branch
from
aeb0906 to
5177aff
Compare
|
Merged manually. |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Apr 15, 2022
CHANGES: ## Features - Add support for dune in watch mode. The lsp server will now display build errors in the diagnostics and offer promotion code actions. - Re-introduce ocamlformat-rpc (ocaml/ocaml-lsp#599, fixes ocaml/ocaml-lsp#495) ## Fixes - Fix workspace symbols that could have a wrong path in some cases ([ocaml/ocaml-lsp#675](ocaml/ocaml-lsp#671))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #656
First commit adds a test that uses a
copy_filesstanza to reproduce the issue. The second commit implements the fix.So instead of taking the filename from the
cmt.cmt_sourcefile, we now use thepos_fnamefrom theMbrowse_raw.nodelocation.It actually fixes also issues with
.pp.mland.mllfiles:.pp.ml (BEFORE)
Screen.Recording.2022-04-13.at.21.20.55.mov
.pp.ml (AFTER)
Screen.Recording.2022-04-13.at.21.17.21.mov
.mll (BEFORE)
Screen.Recording.2022-04-13.at.21.20.05.mov
.mll (AFTER)
Screen.Recording.2022-04-13.at.21.19.14.mov