Fix mutex change of ownership (OpenBSD) #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xguerin
force-pushed
the
feature/openbsd-mutex-fix
branch
from
bc8615c to
6b64236
Compare
|
AFAICT the cause of the failure on Mac is not related to the patch. |
xguerin
force-pushed
the
feature/openbsd-mutex-fix
branch
2 times, most recently
from
055ba81 to
e4639ab
Compare
xguerin
force-pushed
the
feature/openbsd-mutex-fix
branch
from
e4639ab to
a430d82
Compare
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
|
Thanks. A reference about mutexes on openbsd would be handy :) I'll take your word for it though |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Nov 16, 2020
CHANGES: ## Features - Add keyword completion - Add go to declaration functionality to jump to a value's specification in a .mli file (ocaml/ocaml-lsp#294) ## Fixes - ocaml/ocaml-lsp#245: correctly use mutexes on OpenBSD (ocaml/ocaml-lsp#264) - ocaml/ocaml-lsp#268: Do not use vendored libraries when building the lsp package (ocaml/ocaml-lsp#260) - ocaml/ocaml-lsp#271: Clear diagnostics when files are closed - Disable non-prefix completion. There's no reliably way to trigger it and it can be slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD is pretty strict about change of ownership for mutexes (
abort()). This PR addresses that issue by moving mutex locking to their logically owning threads.