Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not handling spaces in parent directory name #471

Closed
reubenrowe opened this issue Jul 6, 2021 · 2 comments · Fixed by ocaml/opam-repository#21741
Closed

Not handling spaces in parent directory name #471

reubenrowe opened this issue Jul 6, 2021 · 2 comments · Fixed by ocaml/opam-repository#21741
Milestone
1.12.3

Comments

@reubenrowe
Copy link

I've encountered a problem using ocaml-lsp-server via the ocamllabs OCaml Platform VSCode plugin, in which I would get a lot of unbound module errors.

My project involves several libraries, and is compiled with dune. The unbound module errors are being given for modules contained in other libraries within the same project.

I observe this behaviour when my project lives in a directory whose name contains spaces. When I rename the directory so that it does not include spaces, IDE support using the OCaml Platform VSCode plugin works fine.

I'm not sure whether this is a problem with ocaml-lsp-server or with its integration with dune.
@reubenrowe
Copy link
Author

This is possibly (probably?) related to issue #459 .

rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Jul 7, 2022
@rgrinberg
[new release] ocaml-lsp-server, lsp and jsonrpc (1.12.3)
541b3ec 
CHANGES:

## Fixes

- Fix a bad interaction between inferred interfaces and promotion code actions
  in watch mode (ocaml/ocaml-lsp#753)

- Fix URI parsing (ocaml/ocaml-lsp#739 fixes ocaml/ocaml-lsp#471 and ocaml/ocaml-lsp#459)
@rgrinberg rgrinberg mentioned this issue Jul 7, 2022
Merged
@rgrinberg rgrinberg added this to the 1.12.3 milestone Jan 13, 2023
@rgrinberg
Copy link
Member

Please re-open if this still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.3
Development

Successfully merging a pull request may close this issue.

[new release] ocaml-lsp-server, lsp and jsonrpc (1.12.3) rgrinberg/opam-repository
2 participants
@rgrinberg @reubenrowe