-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take class methods into account for suggestions #1358
Closed
yannl35133 opened this issue
Aug 21, 2024
· 1 comment
· Fixed by #1363 or ocaml/opam-repository#26995
Closed
Take class methods into account for suggestions #1358
yannl35133 opened this issue
Aug 21, 2024
· 1 comment
· Fixed by #1363 or ocaml/opam-repository#26995
Labels
bug
Something isn't working
Comments
Thanks for your report @yannl35133. It looks like typing the first letter of the method does trigger meaningful completion. It looks like it is indeed an issue with the server. Relevant Merlin test: Query log:
|
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this issue
Aug 23, 2024
Object methods are not completed
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this issue
Aug 23, 2024
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this issue
Aug 23, 2024
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this issue
Aug 26, 2024
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this issue
Aug 26, 2024
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Nov 29, 2024
CHANGES: ## Features - Add custom [`ocamllsp/typeSearch`](/ocaml-lsp-server/docs/ocamllsp/typeSearch-spec.md) request (ocaml/ocaml-lsp#1369) - Make MerlinJump code action configurable (ocaml/ocaml-lsp#1376) - Add custom [`ocamllsp/jump`](/ocaml-lsp-server/docs/ocamllsp/merlinJump-spec.md) request (ocaml/ocaml-lsp#1374) ## Fixes - Fix fd leak in running external processes for preprocessing (ocaml/ocaml-lsp#1349) - Fix prefix parsing for completion of object methods (ocaml/ocaml-lsp#1363, fixes ocaml/ocaml-lsp#1358) - Remove some duplicates in the `selectionRange` answers (ocaml/ocaml-lsp#1368)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Nov 29, 2024
CHANGES: ## Features - Add custom [`ocamllsp/typeSearch`](/ocaml-lsp-server/docs/ocamllsp/typeSearch-spec.md) request (ocaml/ocaml-lsp#1369) - Make MerlinJump code action configurable (ocaml/ocaml-lsp#1376) - Add custom [`ocamllsp/jump`](/ocaml-lsp-server/docs/ocamllsp/merlinJump-spec.md) request (ocaml/ocaml-lsp#1374) ## Fixes - Fix fd leak in running external processes for preprocessing (ocaml/ocaml-lsp#1349) - Fix prefix parsing for completion of object methods (ocaml/ocaml-lsp#1363, fixes ocaml/ocaml-lsp#1358) - Remove some duplicates in the `selectionRange` answers (ocaml/ocaml-lsp#1368)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Nov 29, 2024
CHANGES: ## Features - Add custom [`ocamllsp/typeSearch`](/ocaml-lsp-server/docs/ocamllsp/typeSearch-spec.md) request (ocaml/ocaml-lsp#1369) - Make MerlinJump code action configurable (ocaml/ocaml-lsp#1376) - Add custom [`ocamllsp/jump`](/ocaml-lsp-server/docs/ocamllsp/merlinJump-spec.md) request (ocaml/ocaml-lsp#1374) ## Fixes - Fix fd leak in running external processes for preprocessing (ocaml/ocaml-lsp#1349) - Fix prefix parsing for completion of object methods (ocaml/ocaml-lsp#1363, fixes ocaml/ocaml-lsp#1358) - Remove some duplicates in the `selectionRange` answers (ocaml/ocaml-lsp#1368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you ask for completion after having written
let f (x : < a_method : 'a >) = x#
, you get no useful suggestion, while the only possibility is in facta_method
as per the type ofx
.This kind of suggestions already happens for record fields, and as far as I can see (I'm not an emacs user) it works on emacs for methods.
The text was updated successfully, but these errors were encountered: