Binding operators in occurrence and locate #1405
Conversation
There was a problem hiding this comment.
Thank you for that contribution @mattiase !
Apart from a few small things it looks good to me.
There are still some issues with occurrences but it already improves the situation a lot.
Can you rebase and add a Changelog entry ?
This allows the Locate operation to recognise a binding operator (`let*`, `and+` etc) at the given position.
CHANGES.md
Outdated
| @@ -10,6 +10,7 @@ git version | |||
| - handle `=` syntax in compiler flags (#1409) | |||
| - expose all destruct exceptions in the api (#1437) | |||
| - fix superfluous break in error reporting (#1432) | |||
| - recognise binding operators in locate and occurrences (#1398) | |||
There was a problem hiding this comment.
| - recognise binding operators in locate and occurrences (#1398) | |
| - recognise binding operators in locate and occurrences (#1398, @mattiase) |
There was a problem hiding this comment.
Not really fond of tooting my own horn but you make the rules; changing.
There was a problem hiding this comment.
We usually credit external contributors, but don't feel obliged to do it if you prefer to remain in the shadows :-)
There was a problem hiding this comment.
Thanks, but it's fine to keep it as it is.
Right now this only works when the the `-identifier-at` position indicates a reified binding operator, not an actual use of the operator syntax.
|
Not sure why the CI broke (but it is most probably not related to this PR). The error is: Apparently OCaml 4.14 is installed even if our workflow file specify 4.13... |
|
I will raise a PR to fix that issue. |
Support for binding operators in occurrence and locate
Support for binding operators in occurrence and locate
Find binding operator uses in Occurrence and their definitions in Locate (issue #1398)
Although Locate works from a position where the binding operator syntax is used, Occurrence does not but requires the position to indicate the reified (bracketed) operator.