Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: %{bin-available:..} cycle #9193

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: %{bin-available:..} cycle #9193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d83eb0b
fix: %{bin-available:..} cycle
rgrinberg Nov 15, 2023
4e1b430
Merge branch 'main' into ps/rr/fix____bin_available_____cycle
emillon Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dune_rules/artifacts.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ let binary_available t name =
(match path with
| External e -> Fs_memo.file_exists @@ External e
| In_source_tree e -> Fs_memo.file_exists @@ In_source_dir e
| In_build_dir _ -> Build_system.file_exists path)
| In_build_dir _ -> Memo.return true)
;;

let add_binaries t ~dir l =
Expand Down
6 changes: 0 additions & 6 deletions test/blackbox-tests/test-cases/github9187.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,3 @@ situation. See #9187.
$ touch e.ml

$ dune build
Error: Dependency cycle between:
Computing directory contents of _build/default
-> Computing installable artifacts for package p
-> %{bin-available:e} at dune:11
-> Computing directory contents of _build/default
[1]