fix(engine): small optimization for Patch_back_source_tree sandboxes #8938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to [stat] directories when snapshotting the sandbox in [Patch_back_source_tree]. Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 4a5d2bde-d0f8-4046-92ca-538acca07b37 -->
|
@dkalinichenko-js could you review this one? |
dkalinichenko-js
approved these changes
Oct 18, 2023
rgrinberg
deleted the
ps/rr/fix_engine___small_optimization_for_patch_back_source_tree_sandboxes
branch
|
@dkalinichenko-js Could you please downstream this one? |
This change is originally from @pmwhite fyi, it's already in the code. |
|
@dkalinichenko-js This change has been downstreamed by @pmwhite already? Am I getting that right? If so, whoever did should remove the |
|
@dkalinichenko-js I think you are referring to #8705. It's a very similar piece of code to this one, but in a different part of this file. I don't think we have this change internally yet. (for what it's worth, I came to the same conclusion at first and was very confused, because I didn't remember importing this change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to [stat] directories when snapshotting the sandbox in
[Patch_back_source_tree].
Signed-off-by: Rudi Grinberg [email protected]