test(stdune): Path.drop_prefix doesn't respect path boundaries #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is perhaps an unexpected result of using `Path.drop_prefix`. Perhaps another function `Path.drop_path_prefix` is needed instead if this behaviour is intentional. Signed-off-by: Ali Caglayan <[email protected]>
Merged
|
@anmonteiro since you implemented this function I am interested to hear what you think about this issue. |
|
This looks like a bug in I think that wouldn't break anything existing usage, but I'm eager to see the results of that test run. |
Alizter
deleted the
ps/branch/test_stdune___path_drop_prefix_doesn_t_respect_path_boundaries
branch
Alizter
restored the
ps/branch/test_stdune___path_drop_prefix_doesn_t_respect_path_boundaries
branch
|
Reopening as we don't have an issue. But the tests here have been subsumed by #8961. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps an unexpected result of using
Path.drop_prefix. Perhaps another functionPath.drop_path_prefixis needed instead if this behaviour is intentional.