refactor(dap): hide the implementation of dynamic dependencies #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowleopard
reviewed
Jun 18, 2023
There was a problem hiding this comment.
I'm not sure it's actually an improvement. You are hiding some details, sure, but also make the types less precise. Also, as we discussed, I'm currently doing a lot of changes around dependency representation and would prefer to avoid touching this code for now.
snowleopard
reviewed
Jun 18, 2023
|
We can wait, but I think this change can only help your refactoring. You have one less dependency type to worry about with this change. |
snowleopard
reviewed
Jun 18, 2023
snowleopard
approved these changes
Jun 18, 2023
This was cleared up in src/dune_engine/action_exec.mli in case anyone else is reading. |
The representation of dynamic dependencies as they're implemented by DAP is an implementation detail that the engine shouldn't be concerned with. Instead, we reuse the standard representation of dependencies. Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 7ca7a61a-8237-4043-b716-a937b4073c22 -->
rgrinberg
force-pushed
the
ps/rr/refactor_dap___hide_the_implementation_of_dynamic_dependencies
branch
from
64bcd29 to
cfb7c76
Compare
rgrinberg
deleted the
ps/rr/refactor_dap___hide_the_implementation_of_dynamic_dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The representation of dynamic dependencies as they're implemented by DAP
is an implementation detail that the engine shouldn't be concerned with.
Instead, we reuse the standard representation of dependencies.
Signed-off-by: Rudi Grinberg [email protected]