test(melange): show dependency cycle depending on runtime_deps in target dir #7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
changed the title
anmonteiro
force-pushed
the
anmonteiro/melange-failing-test-eager-runtime-deps
branch
from
086646a to
3260a3e
Compare
…get dir Signed-off-by: Antonio Nuno Monteiro <[email protected]>
anmonteiro
force-pushed
the
anmonteiro/melange-failing-test-eager-runtime-deps
branch
from
3260a3e to
d06505d
Compare
anmonteiro
force-pushed
the
anmonteiro/melange-failing-test-eager-runtime-deps
branch
from
d06505d to
aecf4f4
Compare
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
anmonteiro
force-pushed
the
anmonteiro/melange-failing-test-eager-runtime-deps
branch
from
aecf4f4 to
c3ef970
Compare
anmonteiro
commented
Mar 16, 2023
| Test depending on non-existing paths | ||
|
|
||
| $ mkdir another | ||
| $ mkdir -p another/another-output/another |
There was a problem hiding this comment.
I had only ran the action builder eagerly because of this test, but it looks like creating its target dir in source makes the error pop up again, so it's rather an instance of #7207 and the recursive alias work that's gonna come after it.
rgrinberg
reviewed
Mar 16, 2023
| @@ -31,7 +31,9 @@ Rules created for the assets in the output directory | |||
| [1] | |||
|
|
|||
| $ dune build @mel --display=short | |||
| bash some_dir | |||
There was a problem hiding this comment.
In a separate PR, it would be good to switch this test to sh unless you need some special bash features.
anmonteiro
deleted the
anmonteiro/melange-failing-test-eager-runtime-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.