Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable formatting for a single dune file #6465

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Nov 14, 2022

No description provided.

@emillon emillon requested a review from rgrinberg November 14, 2022 14:51
@rgrinberg
Copy link
Member

Can this test be grouped with the other formatting tests?

@emillon
Copy link
Collaborator Author

emillon commented Nov 15, 2022

formatting.t is a directory test (with a run.t file) which does many things already. what do you think we should do? try to split it into self-contained test, or maybe move it to formatting/feature.t/run.t and add this one under formatting?

@rgrinberg
Copy link
Member

try to split it into self-contained test, or maybe move it to formatting/feature.t/run.t and add this one under formatting?

both sound fine to me

@emillon
Copy link
Collaborator Author

emillon commented Nov 15, 2022

ok I'll do the latter and make a note to myself to do the former someday

@emillon emillon force-pushed the test-formatting-disable-subdir branch from f26c457 to f16be35 Compare November 15, 2022 15:54
@emillon emillon enabled auto-merge (squash) November 15, 2022 16:23
@emillon emillon force-pushed the test-formatting-disable-subdir branch from f16be35 to e3b9e84 Compare November 15, 2022 16:23
@emillon emillon merged commit aa05250 into ocaml:main Nov 15, 2022
@emillon emillon deleted the test-formatting-disable-subdir branch November 15, 2022 16:24
jchavarri added a commit to jchavarri/dune that referenced this pull request Nov 16, 2022
* main:
  test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485)
  chore(nix): make it faster to get melange (ocaml#6347)
  refactor: status db style tweaks (ocaml#6478)
  fix: improve error message for status db (ocaml#6479)
  refactor: remove unused [flags] parameter (ocaml#6480)
  refactor(ctypes): remove pesky aliases (ocaml#6482)
  chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484)
  feature(coq): automatic detection of native
  chore(coq): bump Coq lang to 0.7
  test: disable formatting for a single dune file (ocaml#6465)
  refactor: clean up module compilation (ocaml#6461)
  doc: add button to copy code blocks in Dune manual (ocaml#6428)
  refactor: deforest a set conversion (ocaml#6473)
  refactor: remove temporary map used for sorting (ocaml#6472)
  fix(melange): handle include_subdirs unqualified (ocaml#6475)
jchavarri added a commit to jchavarri/dune that referenced this pull request Nov 16, 2022
* main:
  test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485)
  chore(nix): make it faster to get melange (ocaml#6347)
  refactor: status db style tweaks (ocaml#6478)
  fix: improve error message for status db (ocaml#6479)
  refactor: remove unused [flags] parameter (ocaml#6480)
  refactor(ctypes): remove pesky aliases (ocaml#6482)
  chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484)
  feature(coq): automatic detection of native
  chore(coq): bump Coq lang to 0.7
  test: disable formatting for a single dune file (ocaml#6465)
  refactor: clean up module compilation (ocaml#6461)
  doc: add button to copy code blocks in Dune manual (ocaml#6428)
  refactor: deforest a set conversion (ocaml#6473)
  refactor: remove temporary map used for sorting (ocaml#6472)
  fix(melange): handle include_subdirs unqualified (ocaml#6475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants