Rpc higher priority than build jobs #4743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Refactor
Scheduler.Event.Queue.next
so we have a tangible list of event sources instead of a large function where the level of indentation roughly determines the priority.I think this way it's clearer what's going on. I'm not too worried about allocation of these closures because scheduler events are not supposed to be very numerous.
Then swap the order of
worker_tasks_completed
andjobs_completed
in this list.This is simply to make the priority order make more sense, not really fixing any issue I observed.
The reason I'm looking into this is that I wanted to use the
worker_tasks_completed
mechanism for inotify watcher and there we clearly want the same-ish priority asinvalidation
.