Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc higher priority than build jobs #4743

Merged
merged 5 commits into from
Jun 17, 2021

Conversation

aalekseyev
Copy link
Collaborator

@aalekseyev aalekseyev commented Jun 16, 2021

This PR does two things:

  • Refactor Scheduler.Event.Queue.next so we have a tangible list of event sources instead of a large function where the level of indentation roughly determines the priority.

    I think this way it's clearer what's going on. I'm not too worried about allocation of these closures because scheduler events are not supposed to be very numerous.

  • Then swap the order of worker_tasks_completed and jobs_completed in this list.

    This is simply to make the priority order make more sense, not really fixing any issue I observed.
    The reason I'm looking into this is that I wanted to use the worker_tasks_completed mechanism for inotify watcher and there we clearly want the same-ish priority as invalidation.

Signed-off-by: Arseniy Alekseyev <[email protected]>
Signed-off-by: Arseniy Alekseyev <[email protected]>
@aalekseyev aalekseyev requested a review from rgrinberg June 16, 2021 16:45
Signed-off-by: Arseniy Alekseyev <[email protected]>
Signed-off-by: Arseniy Alekseyev <[email protected]>
@aalekseyev aalekseyev merged commit 7310d10 into ocaml:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants