Add back correct host for ppx.exe #3751
Conversation
Definitely. The current semantics are subtle and we should make sure that they aren't changed accidentally. |
|
You also need to run |
toots
force-pushed
the
host-ppx.exe-bis
branch
from
864ce61 to
c576d99
Compare
|
@rgrinberg Just added the |
toots
force-pushed
the
host-ppx.exe-bis
branch
from
c576d99 to
86a69da
Compare
|
|
|
There are also other tests that use |
|
Hi! Sorry I haven't forgotten this one but haven't found the time to investigate those tests yet. If you're about to release, feel free to include this patch and I'll submit the tests in a separate PR.. |
|
Hi @rgrinberg. I'm afraid it's getting difficult for me to work on adding tests for this feature. I am not familiar enough with the test suite to add it quickly and haven't found the time to study it properly. Any chance that at least the patch could be merged as-is? Currently, |
toots
force-pushed
the
host-ppx.exe-bis
branch
4 times, most recently
from
4e5a6a1 to
d4df43a
Compare
|
Hi again! I've refreshed the PR. It would be nice if it could be considered for inclusion as-is. I'll have another pass at trying to write a test for this but it doesn't seem easy as far as I've been able to see. Meanwhile, this bug is blocking the migration of Thanks! |
|
PS: I also ran |
Signed-off-by: Romain Beauxis <[email protected]>
ghost
|
You are the maintainer of the ocaml-cross repos, so happy to trust you on this. FTR, the testsuite is using cram tests, which is now a public and documented feature of Dune, so adding tests to the Dune testsuite should be easier. We also have a HACKING.md file with a short introduction to Dune's tests. @rgrinberg what do you think of adding this to 2.8.3? |
Signed-off-by: Romain Beauxis <[email protected]>
…ne-action-plugin, dune-private-libs and dune-glob (2.8.3) CHANGES: - Make `patdiff` show refined diffs (ocaml/dune#4257, fixes ocaml/dune#4254, @hakuch) - Fixed a bug that could result in needless recompilation under Windows due to case differences in the result of `Sys.getcwd` (observed under `emacs`). (ocaml/dune#3966, @nojb). - Restore compatibility with Coq < 8.10 for coq-lang < 0.3 , document that `(using coq 0.3)` does require Coq 8.10 at least (ocaml/dune#4224, fixes ocaml/dune#4142, @ejgallego) - Add a META rule for 'compiler-libs.native-toplevel' (ocaml/dune#4175, @AltGr) - No longer call `chmod` on symbolic links (fixes ocaml/dune#4195, @dannywillems) - Dune no longer automatically create or edit `dune-project` files (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino) - Have `dune` communicate the location of the standard library directory to `merlin` (ocaml/dune#4211, fixes ocaml/dune#4188, @nojb) - Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in Path.touch on Windows (ocaml/dune#4223, @dra27) - `dune ocaml-merlin` is now able to provide configuration for source files in the `_build` directory. (ocaml/dune#4274, @voodoos) - Automatically delete left-over Merlin files when rebuilding for the first time a project previously built with Dune `<= 2.7`. (ocaml/dune#4261, @voodoos, @aalekseyev) - Fix `ppx.exe` being compiled for the wrong target when cross-compiling (ocaml/dune#3751, fixes ocaml/dune#3698, @toots) - `dune top` correctly escapes the generated toplevel directives, and make it easier for `dune top` to locate C stubs associated to concerned libraries. (ocaml/dune#4242, fixes ocaml/dune#4231, @nojb) - Do not pass include directories containing native objects when compiling bytecode (ocaml/dune#4200, @nojb)
Fixes: #3698, which is a regression from #2286. Should we add a test for it?