Fix the compilation of OCaml 5 programs on Cygwin #11009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Oct 29, 2024
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Oct 29, 2024
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Oct 29, 2024
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Oct 29, 2024
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
maiste
added a commit
that referenced
this pull request
Oct 30, 2024
* Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 (#10962) * Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 * Fix the compilation of OCaml 5 programs on Cygwin (#11009) strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. * test: backport missing test file --------- Signed-off-by: Etienne Marais <[email protected]> Signed-off-by: Kate <[email protected]> Co-authored-by: Kate <[email protected]> Co-authored-by: Kate <[email protected]>
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like
strdupare not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If-std=c++11is used instead of-std=gnu++11this would fail to compile on non-POSIX platforms such as Cygwin.This fixes an oversight from #10962