Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add versions when opam-file related stanzas were added #10984

Merged

Conversation

Leonidas-from-XIV
Copy link
Collaborator

There is no note about generate_opam_files in the changelog so the only reference seems to be the source. This PR adds that information.

It's per-stanza as the versions where each of the stanzas were added is quite varied, some were even added before opam file generation existed.

@maiste
Copy link
Collaborator

maiste commented Oct 2, 2024

How did you find the versions when it was introduced? (apart from generate_opam_files whose the first mention was used)

@moyodiallo
Copy link
Collaborator

moyodiallo commented Oct 2, 2024

How did you find the versions when it was introduced? (apart from generate_opam_files whose the first mention was used)

I'm also noticing different versions.

@Leonidas-from-XIV
Copy link
Collaborator Author

I created an empty project with (lang dune 1.0) and let dune build tell me the version the dune-lang that the offending stanzas required. I could've also checked the source but this approach is TDD! 😅

Copy link
Collaborator

@maiste maiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try it on my side and get the same number. If this is OK, we could definitely merge it.

There is no note about `generate_opam_files` in the changelog so the
only reference seems to be the source.

Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV Leonidas-from-XIV merged commit 57f435d into ocaml:main Oct 3, 2024
25 of 27 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the opam-file-versionadded branch October 3, 2024 12:53
anmonteiro pushed a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
)

There is no note about `generate_opam_files` in the changelog so the
only reference seems to be the source.

Signed-off-by: Marek Kubica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants