Update HACKING.md to refer to Dune instead of JBuilder #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A handful of `jbuild` references remain, reflecting source code file names. Signed-off-by: Shon Feder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally having time to dig in for #159, I began looking through the contributing and hacking texts today. It occurred to me that making some trivial updates to
HACKING.mdmight be a good proving ground for my PR and commit etiquette.Hopefully updating the naming on this document isn't premature. Note the two remaining instances of
jbuildon lines 60 and 62, reflecting the current source files.