Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdune fails to build: Unbound value Pp.compare #8657

Closed
Tracked by #8316
emillon opened this issue Sep 15, 2023 · 3 comments · Fixed by #8658
Closed
Tracked by #8316

stdune fails to build: Unbound value Pp.compare #8657

emillon opened this issue Sep 15, 2023 · 3 comments · Fixed by #8658
Assignees
Labels

Comments

@emillon
Copy link
Collaborator

emillon commented Sep 15, 2023

Building stdune from the opam file yields the following error

#=== ERROR while compiling stdune.3.11.0~alpha1 ===============================#
# context              2.2.0~alpha3~dev | linux/x86_64 | ocaml-base-compiler.4.13.1 | pinned(https://github.com/ocaml/dune/releases/download/3.11.0_alpha1/dune-3.11.0.alpha1.tbz)
# path                 ~/.opam/4.13/.opam-switch/build/stdune.3.11.0~alpha1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p stdune -j 31 @install
# exit-code            1
# env-file             ~/.opam/log/stdune-7-4b7ddc.env
# output-file          ~/.opam/log/stdune-7-4b7ddc.out
### output ###
# (cd _build/default && /home/opam/.opam/4.13/bin/ocamlc.opt -w -40 -alert -unstable -g -bin-annot -I otherlibs/stdune/src/.stdune.objs/byte -I /home/opam/.opam/4.13/lib/csexp -I /home/opam/.opam/4.13/lib/dyn -I /home/opam/.opam/4.13/lib/ordering -I /home/opam/.opam/4.13/lib/pp -I otherlibs/stdune/dune_filesystem_stubs/.dune_filesystem_stubs.objs/byte -no-alias-deps -open Stdune__ -o otherlibs/stdune/src/.stdune.objs/byte/stdune.cmo -c -impl otherlibs/stdune/src/stdune.ml)
# File "otherlibs/stdune/src/stdune.ml", line 31, characters 21-31:
# 31 |     Ordering.of_int (Pp.compare (fun a b -> Ordering.to_int (compare a b)) x y)
#                           ^^^^^^^^^^
# Error: Unbound value Pp.compare

I bisected this to d4d7c00.

@emillon emillon added the bug label Sep 15, 2023
@emillon emillon self-assigned this Sep 15, 2023
@emillon emillon mentioned this issue Sep 15, 2023
21 tasks
@emillon
Copy link
Collaborator Author

emillon commented Sep 15, 2023

@Alizter looks like we need to release pp to opam as pp.1.2.0. Does that sound good to you?

@rgrinberg
Copy link
Member

Indeed. We should. Let's put a lower bound in our repo though.

@emillon
Copy link
Collaborator Author

emillon commented Sep 15, 2023

I'll deal with that.

emillon added a commit to emillon/dune that referenced this issue Sep 15, 2023
It uses `Pp.compare`, introduced in `pp.1.2.0`.

Fixes ocaml#8657

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit that referenced this issue Sep 18, 2023
It uses `Pp.compare`, introduced in `pp.1.2.0`.

Fixes #8657

Signed-off-by: Etienne Millon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants