Skip to content

Commit

Permalink
chore: use dev version of melange for testing
Browse files Browse the repository at this point in the history
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
  • Loading branch information
anmonteiro committed Feb 17, 2024
1 parent 225564d commit 7f90d9f
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 13 deletions.
15 changes: 13 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ppx_inline_test \
ppxlib \
ctypes \
"utop>=2.6.0" \
"melange>=3.0.0"
"melange"
# Dependencies recommended for developing dune locally,
# but not wanted in CI
DEV_DEPS := \
Expand Down Expand Up @@ -74,14 +74,22 @@ install-ocamlformat:
dev-depext:
opam depext -y $(TEST_DEPS)

.PHONY: melange
melange:
opam pin add -n melange.dev https://github.com/melange-re/melange.git#v4-414-dev

.PHONY: dev-deps
dev-deps:
dev-deps: melange
opam install -y $(TEST_DEPS)

.PHONY: coverage-deps
coverage-deps:
opam install -y bisect_ppx

.PHONY: dev-deps-sans-melange
dev-deps-sans-melange:
opam install -y $(TEST_DEPS)

.PHONY: dev-switch
dev-switch:
opam update
Expand Down Expand Up @@ -109,6 +117,9 @@ test-melange: $(BIN)
test-all: $(BIN)
$(BIN) build @runtest @runtest-js @runtest-coq @runtest-melange

test-all-sans-melange: $(BIN)
$(BIN) build @runtest @runtest-js @runtest-coq

test-coverage: $(BIN)
- $(BIN) build --instrument-with bisect_ppx --force @runtest
bisect-ppx-report send-to Coveralls
Expand Down
10 changes: 8 additions & 2 deletions ci/build-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,16 @@ windows_*)
opamrun pin remove ppx_expect --no-action
opamrun pin remove time_now --no-action

opamrun exec -- make dev-deps
# This should have been:
# opam exec -- make dev-deps
# but melange requires ocaml 4.14 (DKML hasn't been updated as of 2022-11)
opamrun exec -- make dev-deps-sans-melange

echo ======== Run test suite on Unix
opamrun exec -- make test
# This should have been:
# opam exec -- make test
# but melange requires ocaml 4.14 (DKML hasn't been updated as of 2022-11)
opamrun exec -- make test-all-sans-melange
esac

echo ======== Build configurator
Expand Down
14 changes: 7 additions & 7 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
inputs.flake-utils.follows = "flake-utils";
};
melange = {
# When moving the compiler tests to OCaml 5.1, change to v3-51
url = "github:melange-re/melange/v3-414";
# When moving the compiler tests to OCaml 5.1, change to v4-51-dev
url = "github:melange-re/melange/v4-414-dev";
inputs.nixpkgs.follows = "nixpkgs";
inputs.flake-utils.follows = "flake-utils";
};
Expand Down

0 comments on commit 7f90d9f

Please sign in to comment.