refactor(rpc): do not write errors to stderr direct

This will break Tui Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 64b51901-28f8-4142-98d9-aadf7bcd66be
ocaml · Dec 12, 2022 · 2d75445 · 2d75445
1 parent 4dff505
commit 2d75445
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/dune_rpc_impl/dune b/src/dune_rpc_impl/dune
@@ -8,6 +8,7 @@
   dune_stats
   xdg
   memo
+  dune_console
   dune_util
   dune_rpc_private
   dune_rpc_server

diff --git a/src/dune_rpc_impl/import.ml b/src/dune_rpc_impl/import.ml
@@ -1,3 +1,4 @@
 include Stdune
+module Console = Dune_console
 module Dune_rpc = Dune_rpc_private
 module Build_system = Dune_engine.Build_system
diff --git a/src/dune_rpc_impl/server.ml b/src/dune_rpc_impl/server.ml
@@ -63,7 +63,8 @@ module Run = struct
     in
     let with_print_errors f () =
       Fiber.with_error_handler f ~on_error:(fun exn ->
-          Format.eprintf "%a@." Exn_with_backtrace.pp_uncaught exn;
+          Dune_console.print
+            [ Pp.text "Uncaught RPC Error"; Exn_with_backtrace.pp exn ];
           Exn_with_backtrace.reraise exn)
     in
     let run () =