fix: set input_lexbuf when reading binary AST too #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
requested review from
ceastlund,
panglesd and
pitag-ha
as code owners
anmonteiro
force-pushed
the
anmonteiro/lexbuf-for-binary-too
branch
from
12cf329 to
db788a9
Compare
|
@anmonteiro I'm not super familiar with With reason you're using the driver on the marshalled AST resulting from parsing the reason syntax, whereas with regular OCaml syntax, you're using the driver directly on the source files. Are my assumptions correct? |
|
I don’t think so. There’s no dialect present in my repro https://github.com/anmonteiro/no-source-quotation-repro I think this will rather happen on all staged_pps (the instructions in my repro pass the |
|
Ok thanks for the details! I'll add a test for this and merge! |
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
anmonteiro/lexbuf-for-binary-too
branch
from
db788a9 to
0f3350c
Compare
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
NathanReb
force-pushed
the
anmonteiro/lexbuf-for-binary-too
branch
from
0f3350c to
b6e4c93
Compare
NathanReb
approved these changes
Mar 26, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see ocaml/ocaml#12991