Fix source quotation in OCaml 5.2 #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See ocaml/ocaml#12991 for context! |
Signed-off-by: Nathan Rebours <[email protected]>
The compiler removed some logic that was reopening the source file based on `Location.input_name` and instead only rely on `Location.input_lexbuf` for source quotation. This PR changes the way we read source files to stick to what the compiler does in `Pparse` while preserving our features such read from stdin. We now set the input_lexbuf properly. Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
fix-source-quotation-5-2
branch
from
379f004 to
f938704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler removed some logic that was reopening the source file based on
Location.input_nameand instead only rely onLocation.input_lexbuffor source quotation.This PR first adds a test that rely on source quotation. Our test suite failed to catch this bug because all our tests use
OCAML_ERROR_STYLE=short.It then changes the way we read source files to stick to what the compiler does in
Pparsewhile preserving our features such read from stdin. We now set the input_lexbuf properly.