Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light table parsing #14

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Conversation

panglesd
Copy link
Contributor

@panglesd panglesd commented Mar 9, 2023

Each inline item in a cell of a light syntax was interpreted as a paragraph...

This fixes it by wrapping the whole content of a cell inside a paragraph instead.

panglesd added 3 commits March 9, 2023 14:54
Each word is misinterpreted as a paragraph

Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
@panglesd panglesd changed the title Fix light syntax Fix light table parsing Mar 9, 2023
@panglesd
Copy link
Contributor Author

panglesd commented Mar 9, 2023

I added a commit fixing the syntax of ocaml-setup in the CI. I am not sure if this is necessary (maybe it would be better to simply remove the test, since everything is already tested by ocaml-ci).

@@ -31,7 +31,7 @@ jobs:
- name: Setup OCaml ${{ matrix.ocaml-version }}
uses: ocaml/setup-ocaml@v2
with:
ocaml-version: ${{ matrix.ocaml-version }}
ocaml-compiler: ${{ matrix.ocaml-version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this workflow is useless and can be removed. The esy workflow should be kept though.

Only ignore space before and after actual content

Signed-off-by: Paul-Elliot <[email protected]>
Copy link

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonludlam
Copy link
Collaborator

Thanks!

@jonludlam jonludlam merged commit f98cfe3 into ocaml-doc:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants