-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comet #107
Add comet #107
Conversation
- New Task CrossLingualEvaluation is defined. - requirements.txt and setup.py updated accordingly.
Currently CI is failing and one potential reason to that is not disabling the multiprocessing while scoring. There is a bug in the comet implementation, see this issue. |
…ix for num_workers).
Any ideas for CI failing @Sophylax ? Some notes below:
Any similar situations experienced with your tests @ricardorei ? |
Hi @devrimcavusoglu thanks for tagging me on this. Let's see if I can help you I had some problems building the CI for COMET. My solution is to create tests using lightweight encoder models. For example |
which version of COMET are you currently using? |
Thank you for the quick response @ricardorei . I missed the Metrics doc at first sight and only glanced to README, and didn't think there was a lighter model for COMET. Currently with your suggestion the CI problem is solved, thank you very much. One suggesstion from me could be to add/link METRICS.md in README.md. |
Nice! I am happy to help, tag me if you need something else. I'll do that. Actually, I need to update all the documentation, it is extremely outdated... PS: cool repo, I think it's important to have tools to evaluate several metrics and stop people from reporting just BLEU :) |
Thanks @ricardorei, appreciate it. Thanks for the comment about the repo as well, yes one of the milestone is that supplying a diverse set of metrics to people to make the evaluation in NLP more properly :). |
Closes #99.