Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comet #107

Merged
merged 13 commits into from
Mar 21, 2022
Merged

Add comet #107

merged 13 commits into from
Mar 21, 2022

Conversation

devrimcavusoglu
Copy link
Member

Closes #99.

- New Task CrossLingualEvaluation is defined.
- requirements.txt and setup.py updated accordingly.
@devrimcavusoglu
Copy link
Member Author

Currently CI is failing and one potential reason to that is not disabling the multiprocessing while scoring. There is a bug in the comet implementation, see this issue.

@devrimcavusoglu
Copy link
Member Author

Any ideas for CI failing @Sophylax ? Some notes below:

  • Test preserves around 4.5 GB memory, this is a similar case with Prism
  • The PR addressing bug fix for the issue on unbabel/COMET is merged. Still with num_workers=0 it is failing.

Any similar situations experienced with your tests @ricardorei ?

@ricardorei
Copy link

ricardorei commented Mar 15, 2022

Hi @devrimcavusoglu thanks for tagging me on this. Let's see if I can help you

I had some problems building the CI for COMET. My solution is to create tests using lightweight encoder models.

For example [wmt21-cometinho-da](https://github.com/Unbabel/COMET/blob/master/METRICS.md)?

@ricardorei
Copy link

ricardorei commented Mar 15, 2022

which version of COMET are you currently using?

@devrimcavusoglu
Copy link
Member Author

Thank you for the quick response @ricardorei . I missed the Metrics doc at first sight and only glanced to README, and didn't think there was a lighter model for COMET. Currently with your suggestion the CI problem is solved, thank you very much. One suggesstion from me could be to add/link METRICS.md in README.md.

@ricardorei
Copy link

ricardorei commented Mar 15, 2022

Nice! I am happy to help, tag me if you need something else.

I'll do that. Actually, I need to update all the documentation, it is extremely outdated...

PS: cool repo, I think it's important to have tools to evaluate several metrics and stop people from reporting just BLEU :)

@devrimcavusoglu
Copy link
Member Author

Thanks @ricardorei, appreciate it. Thanks for the comment about the repo as well, yes one of the milestone is that supplying a diverse set of metrics to people to make the evaluation in NLP more properly :).

@devrimcavusoglu devrimcavusoglu merged commit 939c1b6 into main Mar 21, 2022
@devrimcavusoglu devrimcavusoglu deleted the add-comet branch March 21, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add COMET
2 participants