Ensure metrics labels are sorted #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <[email protected]>
|
Does it mean receiver does not check this? 😱 |
jessicalins
reviewed
Jul 13, 2022
Signed-off-by: Matej Gera <[email protected]>
squat
approved these changes
Jul 13, 2022
|
Nice find @matej-g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Gera [email protected]
After we started to use the write functionality with
upin our system, we noticed that we started hitting issue on Thanos compactor, complaining about label set not being ordered (see prometheus/prometheus#5372 and related issues).We should ensure that labels are sorted before we write the metrics, in line how the upstream Prometheus code inform us the order should be guaranteed upon instantiation.