tweak horizon example #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea behing Not super important when you make one chart like here. However if you have several charts with different number of bands, I felt it would be more consistent to have the first band of 3 have the same value as the second band of 9. Also, you might want to mix a horizon mark with other marks—e.g., a few points that you'd want to highlight for some reason. But again, these two use cases are not present in that example :) |
Fil
added a commit
that referenced
this pull request
Feb 10, 2022
* clip: true clips the mark to the frame closes #165 related: #181 * reindex clip id * Update src/style.js Co-authored-by: Mike Bostock <[email protected]> * Update src/style.js Co-authored-by: Mike Bostock <[email protected]> * data source (the actual notebook is broken atm) * clippath => clip * reformat horizon plot; nicer heuristic for color * naming consistency * tweak horizon example (#753) * tweak horizon example * use offset, not index * nicer tick labels Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels much more natural to me that the color scale would be defined in
band indexoffset space (0 = the first offset, 1,400 = the second offset, and so on). The previous construction was dependent on the labels being in lexicographic order.I also don’t grok why we can’t use the ordinal sequential color schemes as they are out of the box? Why do we need to recrop them using
range: [1 / (bands + 1), 1 - 1 / (bands + 1)]? That feels like a complex thing to remember when you want to make a horizon chart.