Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This…
I know it’s tempting to put the scale label in the aria-label of the axis because they’re both “labels”, but the current default axis label (e.g., “x-axis”) is a better label than the scale label which in Plot indicates only the abstract dimension of data, i.e. the input, not the output visual channel such as x or y. And if we try to combine the scale label into the axis label, then we have to separate them somehow (e.g., with a comma “x-axis, Date →” or with parens “x-axis (Date)”, though the latter won’t work well since we already use parens for percentages etc.). And then the user can’t set one without affecting the other.
I believe we are supposed to use aria-describedby here, but I would prefer to avoid a random/incrementing id, so I’m hoping that using aria-description will be equivalent. We could switch to aria-describedby if necessary.