make it easier to create a text halo #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
fil/paintOrder
branch
from
f249f52 to
8518555
Compare
mbostock
reviewed
Jan 25, 2022
src/marks/text.js
Outdated
| @@ -39,7 +39,10 @@ export class Text extends Mark { | |||
| {name: "rotate", value: numberChannel(vrotate), optional: true}, | |||
| {name: "text", value: text, filter: nonempty} | |||
| ], | |||
| options, | |||
| { | |||
| ...options.stroke && {paintOrder: "stroke", strokeWidth: 3}, | |||
There was a problem hiding this comment.
The strokeWidth only has an effect if there is a stroke, so we can simply move this to up the defaults declaration. Likewise, we could move the paintOrder up to defaults too and add some logic to style.js so only apply the default paintOrder if there’s both a fill and a stroke.
Alternatively, I was thinking that the strokeWidth would be 3 only if both a fill and stroke are specified, and that it would be 1.5 (or 1?) if only the stroke were specified.
mbostock
force-pushed
the
fil/paintOrder
branch
from
85f2c49 to
e6e3bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by defaulting paintOrder to stroke and strokeWidth to 3 if the stroke option is specified.
supersedes #667
closes #666
Note: I balanced between 3 and 4 for the default, and took the conservative approach. It creates a 1.5px "halo" which is just enough, maybe sometimes a bit too small, but at least never looks gross. Not setting strokeWidth results (as you mentioned) in a 0.5px stroke, which is not a very good default.