“mid” interval transform #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Dec 31, 2021
mbostock
commented
Jan 1, 2022
| } | ||
| if (typeof interval.floor !== "function" || typeof interval.offset !== "function") throw new Error("invalid interval"); | ||
| if (typeof interval.mid !== "function") { |
There was a problem hiding this comment.
This means we’ll have to wrap every interval with this object, even though we won’t end up using it in most places. I think it’d be better to only create the mid function if it’s needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to keep the two transforms distinct: we’ll compute the midpoint of the interval for dot, text, and image, and the extent of the interval for other marks. This also allows the “mid” interval transform to avoid memoization.
In addition to your fix to pass data to the interval’s transform function in case x2 in computed before x1, I’ve also fixed the memoization to be bypassed if the data changes. This isn’t currently possible in Plot, but I could imagine us wanting to support data changing in the future, so fixing while I’m here.