Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carto #36

Closed
wants to merge 1 commit into from
Closed

carto #36

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Dec 3, 2020

I've left lots of question marks in the code; in particular the way the projection flows is wrong (and this forbids faceting).

@Fil
Copy link
Contributor Author

Fil commented Feb 3, 2021

I want to try and see if I can rewrite this as a plugin, without having to access a specific projection scale.

@Fil Fil marked this pull request as draft February 18, 2021 06:36
@Fil
Copy link
Contributor Author

Fil commented Feb 18, 2021

Converted to draft.

@Fil
Copy link
Contributor Author

Fil commented Apr 20, 2021

Rebased, but since this is never going to be part of Plot, the next step is to try and make a plugin version.

@Fil
Copy link
Contributor Author

Fil commented May 2, 2021

A plugin approach works
https://observablehq.com/d/7fe9cd66e7ed57fb

it needs to copy (or use) quite a lot of internals: {applyDirectStyles, applyIndirectStyles, applyTransform, ascending, clamp, create, filter, maybeNumber, maybeColor, positive, title, Style}

@Fil Fil closed this May 2, 2021
@Fil Fil deleted the carto branch May 2, 2021 13:41
@mbostock
Copy link
Member

mbostock commented May 2, 2021

this is never going to be part of Plot

Never say never. After we get the first release out and see the response we can plan out a roadmap and figure out what else we’ll start incorporating into Plot and when. Plugins are a great interim way for us to make functionality available and demonstrate demand for adding features to the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants