tip preferredAnchor #1872
Merged
tip preferredAnchor #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/preferred-tip-anchor
branch
from
9992c6e to
7bfa337
Compare
|
In the tiplineX example, for some values we select an anchor that doesn't fit. (Most probably not related to this PR, since it doesn't change the measurements, so I'll open a new issue) |
Fil
approved these changes
Sep 25, 2023
This was referenced Sep 25, 2023
mbostock
force-pushed
the
mbostock/preferred-tip-anchor
branch
from
439b331 to
b29648c
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* tip preferredAnchor * fix fit tests * document tip options --------- Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a preferredAnchor option for the tip mark, setting the desired anchor when the tip fits. (As opposed to the anchor option, which always uses the specified anchor regardless of whether it fits.) This causes the tip mark to prefer the bottom orientation, except when using the tip option with the y pointer mode, in which case it prefers the left orientation.
This example scatterplot now prefers bottom instead of top-left:
This example horizontal bar chart now prefers left instead of top-left:
I think this is what most people will prefer, and avoids the default “comic book” appearance that Gregor mentioned.
Fixes #1876.