support for fillOpacity in swatch and ramp color legends #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
requested changes
Mar 30, 2023
There was a problem hiding this comment.
The reason I suggested calling it opacity (and not fillOpacity) is that we use the color option for the opacity ramp legend. Also more practically, there is no possible stroke here, so we do not need to distinguish between fill and stroke, and opacity is shorter.
|
My code was really missing a few pieces :-( Now, it's a bummer that we have to select opacity if there is no symbol, fillOpacity if the symbols are filled, and strokeOpacity if they are stroked. Maybe we could support opacity across the board (as well as strokeOpacity and fillOpacity)? |
mbostock
reviewed
Mar 30, 2023
mbostock
reviewed
Mar 30, 2023
mbostock
reviewed
Mar 30, 2023
mbostock
reviewed
Mar 30, 2023
mbostock
force-pushed
the
fil/color-legend-opacity
branch
from
ed7d07f to
b7c3902
Compare
mbostock
approved these changes
Apr 1, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
…q#1407) * support for fillOpacity in swatch and ramp color legends closes observablehq#1356 * opacity * fill opacity it is * use fill-opacity * minimize diff * minimize diff; add default * regenerate test snapshots --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I used fillOpacity and not opacity, for consistency with the symbol legends.
closes #1356